[Webkit-unassigned] [Bug 61170] Zombies should "live" forever

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61170





--- Comment #2 from Oliver Hunt <oliver at apple.com>  2011-05-20 08:50:58 PST ---
(From update of attachment 94180)
View in context: https://bugs.webkit.org/attachment.cgi?id=94180&action=review

> Source/JavaScriptCore/JavaScriptCore.pro:-67
> -    assembler/MacroAssemblerSH4.h \
>      assembler/MacroAssemblerSH4.cpp \
> -    assembler/SH4Assembler.h \

Why remove these?  Or at least why remove them in this patch?

> Source/JavaScriptCore/runtime/JSCell.h:362
> -        return isCell() && asCell() > (JSCell*)0x1ffffffffL && asCell()->isZombie();
> +        return isCell() && asCell()->isZombie();

whoops, i shouldn't have left this in, my bad.

> Source/JavaScriptCore/runtime/WriteBarrier.h:132
> -        ASSERT(!m_cell || !isZombie(m_cell));
> +        ASSERT(!m_cell || value == reinterpret_cast<T*>(1) || !isZombie(m_cell));

What are you testing here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.