[Webkit-unassigned] [Bug 61167] Middle Click a named target opening in foreground in some situation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61167





--- Comment #9 from Shinya Kawanaka <shinyak at google.com>  2011-05-20 03:16:00 PST ---
(In reply to comment #8)
> (From update of attachment 94183 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94183&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:1379
> > +        && !openedBackgroundTab() && !targetFrame->loader()->openedBackgroundTab()) {
> 
> Why do you need to test whether this frame *and* the target frame haven't opened a background tab? Can't the canonical "background"-ness be stored in one place?

Usually the FrameLoader of the source Frame opens a new tab when middle click. however, when there is a tab having target name already, the FrameLoader of that tab opens a new tab. I wanted to unify it, but it became very messy.

> > Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:971
> > +                if (navigationPolicy == WebNavigationPolicyNewBackgroundTab)
> 
> Why does this need to happen in two places?

Because creating new Tab and changing Tab content are different method.

> 
> > Source/WebKit/chromium/src/FrameLoaderClientImpl.h:253
> > +    bool m_openedBackgroundTab;
> 
> Who uses this one?

Sorry, this is my mistake.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.