[Webkit-unassigned] [Bug 61167] Middle Click a named target opening in foreground in some situation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61167





--- Comment #8 from Dominic Cooney <dominicc at chromium.org>  2011-05-20 01:06:23 PST ---
(From update of attachment 94183)
View in context: https://bugs.webkit.org/attachment.cgi?id=94183&action=review

> Source/WebCore/loader/FrameLoader.cpp:1379
> +        && !openedBackgroundTab() && !targetFrame->loader()->openedBackgroundTab()) {

Why do you need to test whether this frame *and* the target frame haven't opened a background tab? Can't the canonical "background"-ness be stored in one place?

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:853
> +      m_webFrame->frame()->loader()->setOpenedBackgroundTab(true);

This should be indented two more spaces.

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:971
> +                if (navigationPolicy == WebNavigationPolicyNewBackgroundTab)

Why does this need to happen in two places?

> Source/WebKit/chromium/src/FrameLoaderClientImpl.h:253
> +    bool m_openedBackgroundTab;

Who uses this one?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.