[Webkit-unassigned] [Bug 61092] [Qt] Fix build after 79407

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 16:36:34 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61092


Chang Shu <cshu at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cshu at webkit.org




--- Comment #3 from Chang Shu <cshu at webkit.org>  2011-05-18 16:36:35 PST ---
> You should explain better what you are doing and why it is needed.
> 
> > Source/WebCore/platform/qt/RenderThemeQt.cpp:75
> > +#ifdef Q_WS_MAC
> >  #include <QMacStyle>
> > +#endif
> 
> This guard should not be needed because the code inside QMacStyle is guarded by 
> 
> #if defined(Q_WS_MAC) && !defined(QT_NO_STYLE_MAC)
> 
> I have no problem to build QtWebKit in my Linux machine. And none of the bots running on different platforms do have any problem as well.
> 
> To add this guard would not cause any harm but it would be nice to make it clear why it is needed.

Enrico, you might want to check your local Qt environment to figure out why the header file is missing. It could be a Qt build issue though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list