[Webkit-unassigned] [Bug 61092] [Qt] Fix build after 79407

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61092





--- Comment #2 from Luiz Agostini <luiz at webkit.org>  2011-05-18 15:49:48 PST ---
(From update of attachment 93989)
View in context: https://bugs.webkit.org/attachment.cgi?id=93989&action=review

> Source/WebCore/ChangeLog:8
> +        * platform/qt/RenderThemeQt.cpp: conditional header inclusion

You should explain better what you are doing and why it is needed.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:75
> +#ifdef Q_WS_MAC
>  #include <QMacStyle>
> +#endif

This guard should not be needed because the code inside QMacStyle is guarded by 

#if defined(Q_WS_MAC) && !defined(QT_NO_STYLE_MAC)

I have no problem to build QtWebKit in my Linux machine. And none of the bots running on different platforms do have any problem as well.

To add this guard would not cause any harm but it would be nice to make it clear why it is needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.