[Webkit-unassigned] [Bug 60412] Page::goToItem doesn't work while loading is deferred

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 13:23:09 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
                 CC|                            |fishd at chromium.org

--- Comment #34 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-05-17 13:23:09 PST ---
(In reply to comment #33)
> > one more question:  why not put this at the top of the function?  it seems like
> > goToItem should have no side-effects in the case that it is deferred.  as is,
> > the client's shouldGoToHistoryItem will be called once when the operation is
> > deferred and once when it becomes un-deferred.  i think it would be safer to
> > put the check at the top of the function.
> It seems incorrect for "m_frame->loader()->client()->shouldGoToHistoryItem(targetItem)" to have any side-effects.  I figured that if the client doesn't want us to go to the given history item now, we shouldn't save the navigation for later, either.

I understand, but the client will presumably answer the question of whether or not they want to go to the given history item later too.  Why ask the client twice?  It doesn't seem to add much value.  It only adds the risk that the client might have side effects.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list