[Webkit-unassigned] [Bug 60412] Page::goToItem doesn't work while loading is deferred

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60412





--- Comment #33 from Ian Henderson <ianh at apple.com>  2011-05-17 11:42:48 PST ---
(In reply to comment #32)
> (From update of attachment 93707 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93707&action=review
> 
> > Source/WebCore/loader/HistoryController.cpp:252
> > +    if (m_defersLoading) {
> 
> one more question:  why not put this at the top of the function?  it seems like
> goToItem should have no side-effects in the case that it is deferred.  as is,
> the client's shouldGoToHistoryItem will be called once when the operation is
> deferred and once when it becomes un-deferred.  i think it would be safer to
> put the check at the top of the function.

It seems incorrect for "m_frame->loader()->client()->shouldGoToHistoryItem(targetItem)" to have any side-effects.  I figured that if the client doesn't want us to go to the given history item now, we shouldn't save the navigation for later, either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.