[Webkit-unassigned] [Bug 57543] -webkit-visual-word does not work on words separated by multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57543


Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93152|0                           |1
        is obsolete|                            |
  Attachment #93152|review?                     |
               Flag|                            |
  Attachment #93675|                            |review?
               Flag|                            |




--- Comment #21 from Xiaomei Ji <xji at chromium.org>  2011-05-16 11:20:25 PST ---
Created an attachment (id=93675)
 --> (https://bugs.webkit.org/attachment.cgi?id=93675&action=review)
patch w/ layout test

(In reply to comment #20)
> (From update of attachment 93152 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93152&action=review
> 
> > Source/WebCore/editing/visible_units.cpp:1183
> > +        // "abc |def |    hij |opq". We are traversing these boxes from right to left. The word 
> > +        // break between "def" and "hij" (which is position 8) is not in box "hij opq", and it 
> > +        // should be added as a word break (the rightmost word break) when traversing box "abc def".
> 
> It's still not clear which of these two boxes correspond to this "box" (current one).

Changed to:
        // "abc |def |    hij |opq". We are traversing these boxes from right to left. When
        // traversing box "abc def", the word break between "def" and "hij" (which is position 8)
        // is added as the rightmost word break.


> 
> > Source/WebCore/editing/visible_units.cpp:1277
> > +    if (wordBreak == previousWordBreak)
> > +        return VisiblePosition();    
> > +   
> 
> Why do we need this early exit?

You are right. They are actually not needed.

> 
> > Source/WebCore/editing/visible_units.cpp:1327
> > +            offsetOfWordBreak = offset;
> > +            isLastWordBreakInBox = false;
> > +            previousWordBreakWasAtBoxStart = true;
> > +            return positionAfterWord;
> 
> This makes me think that we might want to bundle up all these functions as a class.

that could be a good idea. Filed https://bugs.webkit.org/show_bug.cgi?id=60910 for record.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.