[Webkit-unassigned] [Bug 57543] -webkit-visual-word does not work on words separated by multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57543





--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org>  2011-05-13 11:09:41 PST ---
(From update of attachment 93152)
View in context: https://bugs.webkit.org/attachment.cgi?id=93152&action=review

> Source/WebCore/editing/visible_units.cpp:1183
> +        // "abc |def |    hij |opq". We are traversing these boxes from right to left. The word 
> +        // break between "def" and "hij" (which is position 8) is not in box "hij opq", and it 
> +        // should be added as a word break (the rightmost word break) when traversing box "abc def".

It's still not clear which of these two boxes correspond to this "box" (current one).

> Source/WebCore/editing/visible_units.cpp:1277
> +    if (wordBreak == previousWordBreak)
> +        return VisiblePosition();    
> +   

Why do we need this early exit?

> Source/WebCore/editing/visible_units.cpp:1327
> +            offsetOfWordBreak = offset;
> +            isLastWordBreakInBox = false;
> +            previousWordBreakWasAtBoxStart = true;
> +            return positionAfterWord;

This makes me think that we might want to bundle up all these functions as a class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.