[Webkit-unassigned] [Bug 58652] Web Inspector: Background network events collection - add GUI to Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58652





--- Comment #15 from Sergey Vorobyev <sergeyvorobyev at google.com>  2011-05-13 02:48:03 PST ---
(From update of attachment 93311)
View in context: https://bugs.webkit.org/attachment.cgi?id=93311&action=review

>> LayoutTests/http/tests/inspector/inspector-test.js:323
>> +InspectorTest.enableBackgroundEventCollection = function()
> 
> These three methods are specific to network inspection. They should go to network-test.js

done

>> LayoutTests/http/tests/inspector/inspector-test.js:330
>> +        WebInspector.panels.network._toggleBackgroundEventsCollection();
> 
> It's overcomplicated. We don't need to reload page in enableBackgroundEventCollection. If you would like to clear resources you can send disable command followed by enable but I'd rather make the test not depend on the previous state.

done.

>> LayoutTests/http/tests/inspector/inspector-test.js:342
>> +InspectorTest.addToResultNetworkResources = function()
> 
> dumpNetworkResources

done

>> LayoutTests/http/tests/inspector/inspector-test.js:345

> 
> Wouldn't resources.sort() give the same result?

No, it wouldn't

>> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:6
>> +function loadImages(size)
> 
> loadImagesAndReopenFrontend

done. Same done in other tests

>> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:19
>> +function loadImages400()
> 
> Inline this function?

done

>> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:24
>> +function loadImages600()
> 
> ditto

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.