[Webkit-unassigned] [Bug 58652] Web Inspector: Background network events collection - add GUI to Inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 01:46:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58652


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93311|review?                     |review-
               Flag|                            |




--- Comment #14 from Yury Semikhatsky <yurys at chromium.org>  2011-05-13 01:46:24 PST ---
(From update of attachment 93311)
View in context: https://bugs.webkit.org/attachment.cgi?id=93311&action=review

> LayoutTests/http/tests/inspector/inspector-test.js:323
> +InspectorTest.enableBackgroundEventCollection = function()

These three methods are specific to network inspection. They should go to network-test.js

> LayoutTests/http/tests/inspector/inspector-test.js:330
> +        WebInspector.panels.network._toggleBackgroundEventsCollection();

It's overcomplicated. We don't need to reload page in enableBackgroundEventCollection. If you would like to clear resources you can send disable command followed by enable but I'd rather make the test not depend on the previous state.

> LayoutTests/http/tests/inspector/inspector-test.js:342
> +InspectorTest.addToResultNetworkResources = function()

dumpNetworkResources

> LayoutTests/http/tests/inspector/inspector-test.js:345
> +    resources.sort(function(a, b) {return a.url.localeCompare(b.url);});

Wouldn't resources.sort() give the same result?

> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:6
> +function loadImages(size)

loadImagesAndReopenFrontend

> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:19
> +function loadImages400()

Inline this function?

> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:24
> +function loadImages600()

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list