[Webkit-unassigned] [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60439


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92911|review?                     |review+
               Flag|                            |




--- Comment #50 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-05-10 02:33:43 PST ---
(From update of attachment 92911)
View in context: https://bugs.webkit.org/attachment.cgi?id=92911&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:674
> +void TextureMapperNode::syncCompositingStateInternal(GraphicsLayerTextureMapper* graphicsLayer, bool traverseDescendants, TextureMapper* textureMapper)

wouldn't it makes sense to have the traverseDescentants after the textureMapper?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:682
> +        m_state.maskLayer->syncCompositingStateInternal(toGraphicsLayerTextureMapper(graphicsLayer->maskLayer()), false, textureMapper);

I dislike the Internal part... then it is better to find a more proper name

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:684
> +        if (m_state.maskLayer->m_size.isEmpty())
> +            m_state.maskLayer->m_size = m_size;

why only when it is empty? comment?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:688
> +        m_state.replicaLayer->syncCompositingStateInternal(toGraphicsLayerTextureMapper(graphicsLayer->replicaLayer()), false, textureMapper);

can the false be replaced by an enum?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:692
> +    bool visibleRectDirty = true;

IsDirty

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:843
> +        return;

why not just break; ?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:66
> +    static PassRefPtr<TextureMapperAnimation> create(const KeyframeValueList& values) { return adoptRef(new TextureMapperAnimation(values)); }

I would put that one at the top.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.