[Webkit-unassigned] [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60439





--- Comment #51 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-05-10 07:57:03 PST ---
> > Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:674
> > +void TextureMapperNode::syncCompositingStateInternal(GraphicsLayerTextureMapper* graphicsLayer, bool traverseDescendants, TextureMapper* textureMapper)
> 
> wouldn't it makes sense to have the traverseDescentants after the textureMapper?
OK

> > Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:682
> > +        m_state.maskLayer->syncCompositingStateInternal(toGraphicsLayerTextureMapper(graphicsLayer->maskLayer()), false, textureMapper);
> 
> I dislike the Internal part... then it is better to find a more proper name
Actually it seems unnecessary now. I should put everything into syncCompositing state.

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:684
> > +        if (m_state.maskLayer->m_size.isEmpty())
> > +            m_state.maskLayer->m_size = m_size;
> 
> why only when it is empty? comment?
It's a default. Sometimes the mask layer has its own size. Will add a comment.

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:688
> > +        m_state.replicaLayer->syncCompositingStateInternal(toGraphicsLayerTextureMapper(graphicsLayer->replicaLayer()), false, textureMapper);
> 
> can the false be replaced by an enum?
Yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.