[Webkit-unassigned] [Bug 60516] Enable casting between CSSPrimitiveValue and FontWeight enum

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60516





--- Comment #8 from Luke Macpherson <macpherson at chromium.org>  2011-05-09 17:49:10 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 92888 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=92888&action=review
> > 
> > >> Source/WebCore/css/CSSStyleSelector.cpp:-3717
> > >> -                        return;
> > > 
> > > Wait, no, this changes behavior!
> > 
> > The old code returned from the function without doing anything if the identifier was not one of the supported ones. The new code asserts and sets the weight to normal. I don’t think that behavior change is OK.
> 
> I think the default case previously should have been ASSERT_UNREACHABLE.

Moreover, you can see the list of valid values in the parser:
// normal | bold | bolder | lighter | 100 | 200 | 300 | 400 | 500 | 600 | 700 | 800 | 900 | inherit
Any other value would indicate a parser bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.