[Webkit-unassigned] [Bug 60516] Enable casting between CSSPrimitiveValue and FontWeight enum

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60516





--- Comment #7 from Luke Macpherson <macpherson at chromium.org>  2011-05-09 17:27:07 PST ---
(In reply to comment #6)
> (From update of attachment 92888 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92888&action=review
> 
> >> Source/WebCore/css/CSSStyleSelector.cpp:-3717
> >> -                        return;
> > 
> > Wait, no, this changes behavior!
> 
> The old code returned from the function without doing anything if the identifier was not one of the supported ones. The new code asserts and sets the weight to normal. I don’t think that behavior change is OK.

I think the default case previously should have been ASSERT_UNREACHABLE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.