[Webkit-unassigned] [Bug 57543] -webkit-visual-word does not work on words separated by multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57543





--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2011-05-09 15:15:07 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 92380 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=92380&action=review
> > 
> > > Source/WebCore/editing/visible_units.cpp:1160
> > > +static VisiblePosition visuallyFirstWordBreakInBoxInsideBlockWithSameDirectionality(const InlineBox* box, const VisiblePosition& wordBreak, int& offsetOfWordBreak) 
> > 
> > I'm not sure if "visuallyFirstWordBreak" is descriptive here.  How about something like beforeVisuallyFirstWordInBoxInsideBlockWithSameDirectionality?
> 
> It actually is the visually first word break in the box (if it is a word break inside the same box).

But what kind of word break is it?  Is that before a word or after a word?  It's not clear from the function name.

> > 
> > Also, it may not be worth adding this function at all since it's called at exactly one place.  Can we just put this all in previousWordBreakInBoxInsideBlockWithSameDirectionality?
> 
> I do not have strong objections. But separating it out seems more consistent with the current style (making functions more fine grained and more readable), for example, lastWordBreakInBox() is also only used once.

The fact we need such a long function name might imply that this shouldn't really be a function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.