[Webkit-unassigned] [Bug 57543] -webkit-visual-word does not work on words separated by multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57543





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2011-05-09 15:14:50 PST ---
(From update of attachment 92380)
View in context: https://bugs.webkit.org/attachment.cgi?id=92380&action=review

>>> Source/WebCore/editing/visible_units.cpp:1186
>>> +        || (!box->isLeftToRightDirection() && box->prevLeafChild()))) {
>> 
>> I'm not following here.  Shouldn't we be checking box->isLeftToRightDirection() && !box->prevLeafChild() instead?
> 
> The word break collecting here is actually the rightmost word break for a LTR box or leftmost word break for a RTL box.  Given LTR box as an example, we do not need to save its rightmost word break if it is the visually rightmost box (has no nextLeafChild).

But your condition says box->isLTR() AND box->nextLeafChild().  Under this condition, the box is not the rightmost box.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.