[Webkit-unassigned] [Bug 55728] [fileapi] Worker File API calls that create Blobs fail in debug builds due to random number generator thread assertion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55728





--- Comment #27 from Michael Nordman <michaeln at google.com>  2011-05-09 12:52:17 PST ---
(From update of attachment 92526)
Thnx for looking jian!

View in context: https://bugs.webkit.org/attachment.cgi?id=92526&action=review

>> Source/JavaScriptCore/ChangeLog:8

> 
> Probably it is better to create a new bug for this issue.

how about i just merge the two patches into one, define the FLAG (as in adam's patch) and fix the windows bustage (as in my patch)

>> Source/JavaScriptCore/wtf/FastMalloc.cpp:110
>> +#if OS(WINDOWS)
> 
> It might be better to keep the function defintion unguarded and instead ifdef the implementation.

Did you look at how this was done for pthreads in the #else clause and for the cases where WTF_MULTIPLE_THREADS is not defined. Why should anything be different in the OS(WINDOWS) case?

>> Source/JavaScriptCore/wtf/FastMalloc.cpp:121
>> +           && (TlsGetValue(isForibiddenTlsIndex) == (LPVOID)1);
> 
> No need to separate into 2 lines.
> Also better to use static_cast<LPVOID>(1).

ah... of course... the no line is too long rule

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.