[Webkit-unassigned] [Bug 55728] [fileapi] Worker File API calls that create Blobs fail in debug builds due to random number generator thread assertion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 12:37:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=55728





--- Comment #26 from Jian Li <jianli at chromium.org>  2011-05-09 12:37:02 PST ---
(From update of attachment 92526)
View in context: https://bugs.webkit.org/attachment.cgi?id=92526&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=55728

Probably it is better to create a new bug for this issue.

> Source/JavaScriptCore/wtf/FastMalloc.cpp:110
> +#if OS(WINDOWS)

It might be better to keep the function defintion unguarded and instead ifdef the implementation.

> Source/JavaScriptCore/wtf/FastMalloc.cpp:121
> +           && (TlsGetValue(isForibiddenTlsIndex) == (LPVOID)1);

No need to separate into 2 lines.
Also better to use static_cast<LPVOID>(1).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list