[Webkit-unassigned] [Bug 60235] Make RenderStyle::setPageBreakInside() reject unsupported enum values.

Thu May 5 16:30:01 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=60235

--- Comment #6 from Luke Macpherson <macpherson at chromium.org>  2011-05-05 16:30:01 PST ---
(In reply to comment #5)
> (From update of attachment 92379 [details])
> Still need to understand why PBAlways is not a valid value here. You mentioned in another bug that the enums were "too loose".  Is it possible to ever call this with PBALWAYS?  or should we ASSERT not?  In either case we should have a comment her to explain why this check is needed/wanted.

If you look at the spec I linked earlier you'll see that this is not a valid value for this property. It is used for 
'page-break-after' and 'page-break-before' properties, but not 'page-break-inside'.

To answer the question of whether to ASSERT or not, I'll need to see what the parser does, as it is possible the parser accepts the full set of enum values. In that case a user could put page-break-inline: always to trigger the assertion.

> I don't think you actually need the inline.  The compiler implicitly adds inline to all declaration-inline definitions was my understanding.  (But I'm not a c++ expert!)

dglazkov seems pretty adamant about it on 60246, though I think more for expression of intent than because it will change the compiler behavior. I haven't been around long enough to take a stand on issues of accepted style, so I'm just trying to do what I'm told.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.