[Webkit-unassigned] [Bug 60235] Make RenderStyle::setPageBreakInside() reject unsupported enum values.

Thu May 5 16:13:42 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=60235

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92379|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #5 from Eric Seidel <eric at webkit.org>  2011-05-05 16:13:42 PST ---
(From update of attachment 92379)
Still need to understand why PBAlways is not a valid value here. You mentioned in another bug that the enums were "too loose".  Is it possible to ever call this with PBALWAYS?  or should we ASSERT not?  In either case we should have a comment her to explain why this check is needed/wanted.

I don't think you actually need the inline.  The compiler implicitly adds inline to all declaration-inline definitions was my understanding.  (But I'm not a c++ expert!)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.