[Webkit-unassigned] [Bug 54181] Implement Page Visibility API.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 12:36:14 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=54181





--- Comment #25 from Shishir Agrawal <shishir at chromium.org>  2011-05-05 12:36:13 PST ---
(From update of attachment 92357)
View in context: https://bugs.webkit.org/attachment.cgi?id=92357&action=review

>> LayoutTests/fast/events/page-visibility-iframe-delete-test.html:13
>> +window.jsTestIsAsync = true;
> 
> Just a consistency thing, we usually just do var jsTestIsAsync instead of window. Same comments in this file apply to other tests.

Done in all.

>> LayoutTests/fast/events/page-visibility-iframe-delete-test.html:14
>> +window.successfullyParsed = false;
> 
> This isn't necessary

Done in all.

>> LayoutTests/fast/events/page-visibility-iframe-delete-test.html:52
>> +    window.successfullyParsed = true;
> 
> This should just be a var successfullyParsed at the end of the inline script block here. finishJSTest will still control the TEST COMPLETE message.

Changed in all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list