[Webkit-unassigned] [Bug 54181] Implement Page Visibility API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54181





--- Comment #24 from Tony Gentilcore <tonyg at chromium.org>  2011-05-05 03:54:50 PST ---
(From update of attachment 92357)
View in context: https://bugs.webkit.org/attachment.cgi?id=92357&action=review

Everything else LGTM to me now. Darin, could you double check that you are happy with the chromium API updates?

> LayoutTests/fast/events/page-visibility-iframe-delete-test.html:13
> +window.jsTestIsAsync = true;

Just a consistency thing, we usually just do var jsTestIsAsync instead of window. Same comments in this file apply to other tests.

> LayoutTests/fast/events/page-visibility-iframe-delete-test.html:14
> +window.successfullyParsed = false;

This isn't necessary

> LayoutTests/fast/events/page-visibility-iframe-delete-test.html:52
> +    window.successfullyParsed = true;

This should just be a var successfullyParsed at the end of the inline script block here. finishJSTest will still control the TEST COMPLETE message.

> Source/WebKit/chromium/features.gypi:78
> +        'ENABLE_PAGE_VISIBILITY_API=1',

The upstream tests will run fine with this enabled now. But chromium's build/features_override.gypi will override this flag to disable it. That means when the tests run on the chromium bots they will fail.

So the cleanest course to land this is to:
1 disable it in this patch and skip the new tests for chromium as well
2 submit a chromium patch to enable it there
3 submit a follow-up webkit patch to enable it here and unskip the tests

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.