[Webkit-unassigned] [Bug 56375] [Qt] PageGroup::closeLocalStorage() should be called when the app quits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56375


Joe Wild <joseph.wild at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joseph.wild at nokia.com




--- Comment #11 from Joe Wild <joseph.wild at nokia.com>  2011-05-02 16:07:12 PST ---
(In reply to comment #9)
> (From update of attachment 91961 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91961&action=review

> Is this fixing any real world problem? a crash or what ever? can not this be tested?

Very good question.  Maybe I jumped the gun on fixing this one.

I believe this error was originally reported as
http://bugreports.qt.nokia.com/browse/QTWEBKIT-263.  It
indicates that closeLocalStorage is called on Mac and Windows, 
and probably should be called on other platforms too.  It does
not sound like a real world problem.

The solutions pointed at on other platforms call both closeLocalStorage
and IconDatabase::close().  Investigating on QtWebKit Linux, I do not
see closeLocalStorage() do anything because the are no PageGroups created.
Local Storage read/write in handled else where in WebCore::StorageAreaSync.
And if I don't not call IconDatabase::close(), I do not see it getting called.

I was thinking the most conservative approach was to make sure these were
called on the QtWebKit platforms.  Now I'm thinking that we should ignore it
unless we have stronger evidence it is needed.

Comments?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.