[Webkit-unassigned] [Bug 26667] Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26667





--- Comment #7 from opendarwin at lapcatsoftware.com  2011-03-30 17:19:27 PST ---
(In reply to comment #6)
> (From update of attachment 86129 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86129&action=review
> 
> > Source/WebKit/mac/WebView/WebHTMLView.mm:4388
> > +    if (_private->closed)
> > +        return [super performKeyEquivalent:event];
> 
> While it’s OK to add the _private->closed check, I’m not sure it’s the best fix. There are many other entry points that do not guard this.
> 
> I suggest instead changing the assertion.
> 
>     ASSERT(_private->closed || [self _webView]);

I don't believe that would be a good fix, because while it trivially solves the assertion failure, it makes the method logic flawed. For example:

    if (![[[self _webView] preferences] respectStandardStyleKeyEquivalents])
        return NO;

The conditional is accidentally satisfied because [self _webView] is nil, regardless of the preference setting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.