[Webkit-unassigned] [Bug 26667] Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 13:30:02 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=26667





--- Comment #6 from Darin Adler <darin at apple.com>  2011-03-30 13:30:02 PST ---
(From update of attachment 86129)
View in context: https://bugs.webkit.org/attachment.cgi?id=86129&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:4388
> +    if (_private->closed)
> +        return [super performKeyEquivalent:event];

While it’s OK to add the _private->closed check, I’m not sure it’s the best fix. There are many other entry points that do not guard this.

I suggest instead changing the assertion.

    ASSERT(_private->closed || [self _webView]);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list