[Webkit-unassigned] [Bug 56286] layout test checksums should be embedded in the png as a comment

Tue Mar 29 10:05:27 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56286

--- Comment #8 from Tony Chang <tony at chromium.org>  2011-03-29 10:05:27 PST ---
(In reply to comment #7)
> My concern is what we do in the interim where Chromium does this. I guess we check for the checksum first, so it just works?

That's correct.  We first check to see if there's a checksum and only if one doesn't exist do we look at the png comment.

> Also, it would be nice for the layout test dashboard to be able to show the checksums for easily comparing the images from different ports. Although, I guess it would be better if the dashboard just let you diff any two images.

This should be possible to do in JS via XHR.  I think we need to add "Access-Control-Allow-Origin: *" to build.chromium.org/f/chromium/layout_test_results/ so we can fetch the resource, but otherwise this seems possible.  I'll talk to the bot admins to see what needs to be done to allow this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.