[Webkit-unassigned] [Bug 56286] layout test checksums should be embedded in the png as a comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 21:02:34 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56286


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jparent at google.com




--- Comment #7 from Ojan Vafai <ojan at chromium.org>  2011-03-28 21:02:34 PST ---
I like the idea. Certainly, if we can get all ports to do it this way it'd be better. My concern is what we do in the interim where Chromium does this. I guess we check for the checksum first, so it just works?

Also, it would be nice for the layout test dashboard to be able to show the checksums for easily comparing the images from different ports. Although, I guess it would be better if the dashboard just let you diff any two images.

As for your pros/cons, I don't see any benefit in people manually editing checksums.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list