[Webkit-unassigned] [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56397


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com,
                   |                            |kling at webkit.org,
                   |                            |lars at trolltech.com,
                   |                            |mrobinson at webkit.org,
                   |                            |xan.lopez at gmail.com




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-28 22:12:47 PST ---
(In reply to comment #7)
> Right, it's misleading for chromium. What would be the preferred way of doing this? Should I:
> 1. Change the text to read something like "FAIL on chromium; PASS on other platforms"?
> 2. Somehow fork the test itself for chromium? (I only saw a way to specify a platform-specific expected.ext.)
> Other ways?

Put a test in LayoutTests/platform/chromium/.  IMO, there's no need to add a test for other ports.

> >> Source/WebCore/page/Chrome.cpp:62
> >> +}
> > 
> > I don't think this is the right way to do it if we want to make decisions per port.  We should add a new callback to WebView or some other class instead.
> 
> Darin (Fisher) explicitly didn't want this (decision to suppress alerts) to be something platform-specific. Though the current patch only enables it for chromium, the goal is to convince other platforms, and make it the default behaviour eventually.

If we're trying to convince other platforms to do the same on other ports, then the right approach should be to convince others first, then implement this patch. It's generally a bad idea to introduce a behavioral difference between ports that is visible to JavaScript.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.