[Webkit-unassigned] [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events

Mon Mar 28 21:42:43 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56397

--- Comment #8 from Sreeram Ramachandran <sreeram at google.com>  2011-03-28 21:42:43 PST ---
(From update of attachment 86035)
View in context: https://bugs.webkit.org/attachment.cgi?id=86035&action=review

>>> LayoutTests/fast/loader/unload-alert.html:9
>>> +  prompt("PASS", "PASS");
>> 
>> This test doesn't make sense on chromium, does it?  If any of PASS appear on chromium platform, it actually failed, right?  I don't think it's clear at all from the test output or from the comment here.
> 
> Right, it's misleading for chromium. What would be the preferred way of doing this? Should I:
> 1. Change the text to read something like "FAIL on chromium; PASS on other platforms"?
> 2. Somehow fork the test itself for chromium? (I only saw a way to specify a platform-specific expected.ext.)
> Other ways?

Looking closer, it appears that LayoutTests/platform can also contain .html files, and not just expected.txt files. I'll use that to fork the test for chromium (and add the overridden one to Skipped, if needed).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.