[Webkit-unassigned] [Bug 56354] Web Inspector: empty, non-functional window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56354





--- Comment #9 from opendarwin at lapcatsoftware.com  2011-03-24 14:31:55 PST ---
(In reply to comment #8)
> (From update of attachment 86759 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86759&action=review
> 
> Thanks for fixing this. I have to put r- for the poor email in the changelog + nit on the null comparison.
> 
> > Source/WebCore/ChangeLog:1
> > +2011-03-24  Jeff Johnson  <lapcatsoftware.com>
> 
> This should contain your email.

I actually left the full address out on purpose, because after my last patch, which did contain an email address, I started receiving a ton of spam at that address, whereas I had never received spam at that address before. Is there some way I can leave out the email? I'd rather be anonymous than spammed. ;-)

> > Source/WebCore/inspector/front-end/Settings.js:117
> > +        if (window.localStorage === null)
> 
> I'd rather use window.localStorage == null in order to allow undefined value. Have you checked that localStorage is null both for v8 and jsc bindings?

I don't think there would be a difference between V8 and JSC, because the value comes from DOMWindow::sessionStorage():

https://trac.webkit.org/browser/trunk/Source/WebCore/page/DOMWindow.cpp

That said, I'm not opposed to switching operators if you prefer.

I should also note that I've filed this related bug:

https://bugs.webkit.org/show_bug.cgi?id=56703

If the linked bug is implemented, then we'd need to wrap a try around the check as opposed to (or in addition to) checking for null. However, I'd rather fix the web inspector now and possibly revise it later if and when the SECURITY_ERR change is implemented. I don't know how much opposition there would be to throwing a SECURITY_ERR.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.