[Webkit-unassigned] [Bug 56354] Web Inspector: empty, non-functional window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56354


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86759|review?                     |review-
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2011-03-24 11:17:54 PST ---
(From update of attachment 86759)
View in context: https://bugs.webkit.org/attachment.cgi?id=86759&action=review

Thanks for fixing this. I have to put r- for the poor email in the changelog + nit on the null comparison.

> Source/WebCore/ChangeLog:1
> +2011-03-24  Jeff Johnson  <lapcatsoftware.com>

This should contain your email.

> Source/WebCore/inspector/front-end/Settings.js:117
> +        if (window.localStorage === null)

I'd rather use window.localStorage == null in order to allow undefined value. Have you checked that localStorage is null both for v8 and jsc bindings?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.