[Webkit-unassigned] [Bug 56928] [Qt] Bottom border of an inline is cut if it is 1 pixel wide and left or right border is thicker.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56928





--- Comment #10 from Benjamin Poulain <benjamin at webkit.org>  2011-03-23 14:48:34 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=86687&action=review

I really don't like that. That means polygons will have antialiasing or not depending on arbitrary conditions.

First, could you explain why the problem exists, and why antialiasing fixes it?

> Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp:455
> +    // Force antialiasing hint when drawing a border of 1 pixel width

This comment does not add any value, because it does not say why it is needed.
The next line has the same information as the comment.
<Kenneth>And the sentence must end with a dot to be a sentence</Kenneth> :)

> Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp:462
> +    if (forceAntialiasHint)
> +        p->setRenderHint(QPainter::Antialiasing, true);
> +    else
> +        p->setRenderHint(QPainter::Antialiasing, shouldAntialias);

This won't fly. I am not against enabling antialiasing by default if there is a good reason for it, but enabling it for a special case is not a good idea.
Don't the default render hint include antialiasing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.