[Webkit-unassigned] [Bug 56928] [Qt] Bottom border of an inline is cut if it is 1 pixel wide and left or right border is thicker.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56928


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86687|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #9 from Andreas Kling <kling at webkit.org>  2011-03-23 14:41:20 PST ---
(From update of attachment 86687)
View in context: https://bugs.webkit.org/attachment.cgi?id=86687&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp:456
> +    // Force antialiasing hint when drawing a border of 1 pixel width
> +    bool forceAntialiasHint = (npoints == 4 && polygon.boundingRect().height() == 1);

Since this is a workaround for a bug in Qt's X11 paint engine, I think we should make that clear by either:

A) Making the workaround QT_WS_X11 and QPaintEngine::X11 specific (just like drawLineForText does.)
B) Including a comment about why we're doing this.
C) Both.

I personally prefer C, but all are fine with me. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.