[Webkit-unassigned] [Bug 56055] Hook up new AppKit autocorrection UI with WK2.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56055





--- Comment #13 from Jia Pu <jpu at apple.com>  2011-03-23 09:33:39 PST ---
(In reply to comment #12)
> (From update of attachment 86516 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86516&action=review
> 
> > Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm:103
> > +    m_wasDismissedExternally = dismissingExternally;
> 
> I don’t think we really want to set this to false if it was already set to true, and this was called an extra redundant time.

Sorry, I don't quite follow this comment. 

Every time dismissInternal() is called, we update m_wasDismissedExternally to keep track whether the dismissal is issued by caller who explicitly call dismiss() and dismissSoon(), in which case dismissingExternally is true. When dismissInternal() is called by ~CorrectionPanel() or show(), this argument is false. And in each of  these cases, dismissInternal() is called only once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.