[Webkit-unassigned] [Bug 56055] Hook up new AppKit autocorrection UI with WK2.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56055





--- Comment #12 from Darin Adler <darin at apple.com>  2011-03-22 18:19:39 PST ---
(From update of attachment 86516)
View in context: https://bugs.webkit.org/attachment.cgi?id=86516&action=review

No time for a complete review, but I did get a chance to look over part of this.

> Source/WebKit/mac/WebCoreSupport/CorrectionPanel.h:46
> +    WTF::String dismissSoon(WebCore::ReasonForDismissingCorrectionPanel);
> +    static void recordAutocorrectionResponse(WebView*, NSCorrectionResponse, const WTF::String& replacedString, const WTF::String& replacementString);

This should just be String, not WTF::String.

> Source/WebKit/mac/WebCoreSupport/CorrectionPanel.h:57
> +    WTF::RetainPtr<WebView> m_view;
> +    WTF::RetainPtr<NSString> m_resultForSynchronousDismissal;
> +    WTF::RetainPtr<NSCondition> m_resultCondition;

This should just be RetainPtr, not WTF::RetainPtr.

> Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm:103
> +    m_wasDismissedExternally = dismissingExternally;

I don’t think we really want to set this to false if it was already set to true, and this was called an extra redundant time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.