[Webkit-unassigned] [Bug 56651] Web Inspector: migrate Inspector.json to valid JSON types.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56651


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86267|review?                     |review+
               Flag|                            |




--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2011-03-21 00:38:34 PST ---
(From update of attachment 86267)
View in context: https://bugs.webkit.org/attachment.cgi?id=86267&action=review

Please address comments before landing.

> Source/WebCore/inspector/InspectorConsoleAgent.cpp:237
> +    int messageCount = m_consoleMessages.size();

If you are changing type of the counter, it should become size_t, not int.

>> Source/WebCore/inspector/InspectorConsoleAgent.h:97
>> +    HashMap<String, int> m_counts;
> 
> ditto

I agree, I'd rather leave unsigned as value type here and cast if needed when formatting protocol messages.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.