[Webkit-unassigned] [Bug 56651] Web Inspector: migrate Inspector.json to valid JSON types.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 19 11:36:14 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56651





--- Comment #2 from Ilya Tikhonovsky <loislo at chromium.org>  2011-03-19 11:36:14 PST ---
(From update of attachment 86267)
View in context: https://bugs.webkit.org/attachment.cgi?id=86267&action=review

lgtm

> Source/WebCore/inspector/InspectorConsoleAgent.cpp:238
> +    int messageCount = m_consoleMessages.size();
> +    for (int i = 0; i < messageCount; ++i)

why did you change this?

> Source/WebCore/inspector/InspectorConsoleAgent.h:97
> -    unsigned m_expiredConsoleMessageCount;
> -    HashMap<String, unsigned> m_counts;
> +    int m_expiredConsoleMessageCount;
> +    HashMap<String, int> m_counts;

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list