[Webkit-unassigned] [Bug 51106] [Qt] Implement the fast font path for Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51106





--- Comment #11 from Andreas Kling <kling at webkit.org>  2011-03-19 09:54:24 PST ---
(In reply to comment #10)
> Would be nice if this compiled on Qt 4.7 as well, which is what I suppose the buildbots are running?

That's a must-have obviously.

> > Source/WebCore/WebCore.pro:3086
> > +!lessThan(QT_MAJOR_VERSION,4):!lessThan(QT_MINOR_VERSION, 8):HAVE_QGLYPHS=1
> 
> why no space before 4?

Will fix. Though now that I think of it, we could just use QT_VERSION_CHECK and check for 4.8 instead of using a HAVE(QGLYPHS) macro..

> > Source/WebCore/platform/graphics/Font.cpp:151
> > +#if PLATFORM(QT) && HAVE(QGLYPHS)
> > +    if (context->textDrawingMode() & TextModeStroke || context->contextShadow()->m_type != ContextShadow::NoShadow)
> > +        codePathToUse = Complex;
> > +#endif
> 
> Why is this not in the codePath method? any particular reason?

The codePath method doesn't have access to a GraphicsContext.

> > Source/WebCore/platform/graphics/qt/FontQt.cpp:353
> > +    // Shadowed text should always take the complex path.
> 
> Text with shadow? Shadowed sounds a bit strange to me

Agree, will change.

> > Source/WebCore/platform/graphics/qt/FontQt.cpp:359
> > +    QVector<quint32> glyphIndexes;
> 
> Indices?

Both are valid words, I would normally call it Indices myself, but in this case the Qt API calls them glyphIndexes so I used the same name for the variable.

> > Source/WebCore/platform/graphics/qt/GlyphPageTreeNodeQt.cpp:54
> > +\
> 
> What is this for?

It improves performance about 200%. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.