[Webkit-unassigned] [Bug 51106] [Qt] Implement the fast font path for Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51106





--- Comment #10 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-18 14:56:27 PST ---
(From update of attachment 86213)
View in context: https://bugs.webkit.org/attachment.cgi?id=86213&action=review

Would be nice if this compiled on Qt 4.7 as well, which is what I suppose the buildbots are running?

> Source/WebCore/WebCore.pro:3086
> +!lessThan(QT_MAJOR_VERSION,4):!lessThan(QT_MINOR_VERSION, 8):HAVE_QGLYPHS=1

why no space before 4?

> Source/WebCore/platform/graphics/Font.cpp:151
> +#if PLATFORM(QT) && HAVE(QGLYPHS)
> +    if (context->textDrawingMode() & TextModeStroke || context->contextShadow()->m_type != ContextShadow::NoShadow)
> +        codePathToUse = Complex;
> +#endif

Why is this not in the codePath method? any particular reason?

> Source/WebCore/platform/graphics/qt/FontQt.cpp:353
> +    // Shadowed text should always take the complex path.

Text with shadow? Shadowed sounds a bit strange to me

> Source/WebCore/platform/graphics/qt/FontQt.cpp:359
> +    QVector<quint32> glyphIndexes;

Indices?

> Source/WebCore/platform/graphics/qt/GlyphPageTreeNodeQt.cpp:54
> +\

What is this for?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.