[Webkit-unassigned] [Bug 56573] Expose the shadow DOM to DumpRenderTree JS tests.

Fri Mar 18 10:16:36 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56573

Ami Fischman <fischman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dglazkov at chromium.org
         Depends on|                            |53020

--- Comment #3 from Ami Fischman <fischman at chromium.org>  2011-03-18 10:16:36 PST ---
Thanks for the (p)review, Dimitri!
Questions:
1) Is whitespace-removal considered worthy of its own CL in webkit-land?  What removal happened was automatically done by my editor setup, and I was skittish about it, since I couldn't find a policy about whether WS removal was considered helpful, harmful, or neutral.

2) For the other ports of DumpRenderTree: I hacked on chromium until I had something that worked, but I don't really understand the relationship between the different LTC classes.  Is the full list:
./Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
./Tools/DumpRenderTree/LayoutTestController.h
./Tools/DumpRenderTree/chromium/LayoutTestController.h
?  If yes, can you point me at the equivalents of convertNPVariantToV8Object for the first two?  (and hints about how I might test any changes I make, esp. on a linux machine :)).

3) By your #3 did you mean you thought I still had changes to make to the v-c-i-m-d.html test, or just that checking in the change I already have for it is going to depend on the previous items (and your change)?

I look forward to you landing 53020 :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.