[Webkit-unassigned] [Bug 56573] Expose the shadow DOM to DumpRenderTree JS tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56573





--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-03-18 09:28:28 PST ---
(From update of attachment 86071)
View in context: https://bugs.webkit.org/attachment.cgi?id=86071&action=review

I see three excellent patches here:
1) One that removes whitespace
2) One that introduces layoutTestController.shadowRoot
3) One that changes video-controls-in-media-document to not use pixel tests.

And hopefully, I will flip over HTMLMediaElement to use proper shadow DOM before you finish 3. If not, you will need to keep nagging me! :)

> Source/WebCore/rendering/MediaControlElements.cpp:-72
> -    setShadowHost(mediaElement);

Unfortunately, this is not yet ready for flip-over to use the new shadow DOM. Please watch bug 53020, where I am trying to just that.

> Source/WebCore/rendering/MediaControlElements.cpp:89
> +    mediaElement->setShadowRoot(element);

Ditto. This is not the right spot to set the shadow root.

> Source/WebCore/rendering/MediaControlElements.cpp:97
> +    shadowHost()->setShadowRoot(0);

Ditto.

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:176
> +    bindMethod("shadowRoot", &LayoutTestController::shadowRoot);

This is great, but please don't forget about other ports in the final patch. They will be sad and cry all night if you don't visit them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.