[Webkit-unassigned] [Bug 56458] User media videoconferencing patch 0: adding compilation guards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56458





--- Comment #7 from Leandro Graciá Gil <leandrogracia at chromium.org>  2011-03-17 10:30:35 PST ---
(In reply to comment #6)
> (From update of attachment 86049 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86049&action=review
> 
> > Source/WebKit/chromium/features.gypi:86
> > +        'ENABLE_USER_MEDIA=1',
> 
> 'ENABLE_USER_MEDIA' doesn't tell me anything about what feature it enables. I realize that the spec uses "user media" in the interface names, eg. NavigatorUserMedia, getUserMedia(), etc, but the term didn't mean anything to me until I looked at the spec and it even after reading the spec it doesn't make me think  "video conferencing". 
> 
> I don't have any great suggestions, maybe 'ENABLE_MEDIA_STREAM_API'?

Good suggestion. I'm not very convinced about ENABLE_USER_MEDIA either, but couldn't figure anything much better. I'll make the changes to ENABLE_MEDIA_STREAM_API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.