[Webkit-unassigned] [Bug 56458] User media videoconferencing patch 0: adding compilation guards

Thu Mar 17 09:55:05 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56458

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86049|review?                     |review-
               Flag|                            |

--- Comment #6 from Eric Carlson <eric.carlson at apple.com>  2011-03-17 09:55:05 PST ---
(From update of attachment 86049)
View in context: https://bugs.webkit.org/attachment.cgi?id=86049&action=review

> Source/WebKit/chromium/features.gypi:86
> +        'ENABLE_USER_MEDIA=1',

'ENABLE_USER_MEDIA' doesn't tell me anything about what feature it enables. I realize that the spec uses "user media" in the interface names, eg. NavigatorUserMedia, getUserMedia(), etc, but the term didn't mean anything to me until I looked at the spec and it even after reading the spec it doesn't make me think  "video conferencing". 

I don't have any great suggestions, maybe 'ENABLE_MEDIA_STREAM_API'?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.