[Webkit-unassigned] [Bug 56421] Devirtualize isContentEditable and isRichlyContentEditable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56421





--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-15 19:14:51 PST ---
Thanks for the review as always.

(In reply to comment #9)
> (From update of attachment 85891 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85891&action=review
> 
> > Source/WebCore/dom/Node.cpp:719
> > +    // Ideally we'd call ASSERT!needsStyleRecalc()) here, but
> 
> Missing parenthesis. I know you just moved this, but still.

Oh yeah, I didn't realize that.  Will fix.

> > Source/WebCore/dom/Node.cpp:724
> > +    const Node* node = this;
> > +    while (node) {
> 
> I’d write this as a for loop. That will work really well if both sides end up doing node->parentNode, but it’s OK even without that.
> 
>     for (const Node* node = this; node; )

Okay, will do.  We should really be calling parentNode for both cases.  I bet the reason we haven't realized this bug is because shadow DOM's root element is almost always editable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.