[Webkit-unassigned] [Bug 56421] Devirtualize isContentEditable and isRichlyContentEditable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56421


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85891|review?                     |review+
               Flag|                            |




--- Comment #9 from Darin Adler <darin at apple.com>  2011-03-15 19:10:01 PST ---
(From update of attachment 85891)
View in context: https://bugs.webkit.org/attachment.cgi?id=85891&action=review

> Source/WebCore/dom/Node.cpp:719
> +    // Ideally we'd call ASSERT!needsStyleRecalc()) here, but

Missing parenthesis. I know you just moved this, but still.

> Source/WebCore/dom/Node.cpp:724
> +    const Node* node = this;
> +    while (node) {

I’d write this as a for loop. That will work really well if both sides end up doing node->parentNode, but it’s OK even without that.

    for (const Node* node = this; node; )

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.