[Webkit-unassigned] [Bug 56350] Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 12:32:28 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56350


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85827|review?                     |review+
               Flag|                            |




--- Comment #9 from Jeremy Orlow <jorlow at chromium.org>  2011-03-15 12:32:27 PST ---
(From update of attachment 85827)
View in context: https://bugs.webkit.org/attachment.cgi?id=85827&action=review

r=me

> Source/WebCore/storage/IDBDatabaseCallbacksImpl.h:45
> +    void unRegisterDatabase(IDBDatabase*);

How do we camelCaseThis elsewhere?  I think usually unregister rather than unRegister?

> Source/WebCore/storage/IDBDatabaseCallbacksImpl.h:51
> +    // If a RefPtr were used here, there'd be a cycle and the ref counting

It seems like this could be more concise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list