[Webkit-unassigned] [Bug 56350] Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56350





--- Comment #8 from David Grogan <dgrogan at chromium.org>  2011-03-15 11:04:54 PST ---
(From update of attachment 85752)
View in context: https://bugs.webkit.org/attachment.cgi?id=85752&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> Please add some more detail and explain why it only affects multi-process.

done

>> Source/WebCore/storage/IDBDatabase.h:118
>> +    RefPtr<IDBDatabaseCallbacks> m_databaseCallbacks;
> 
> Save the impl here.

done

>> Source/WebCore/storage/IDBDatabaseCallbacks.h:36
>> +class IDBDatabase;
> 
> don't add

done

>> Source/WebCore/storage/IDBDatabaseCallbacks.h:43
>> +    virtual void unRegisterDatabase(IDBDatabase*) { ASSERT_NOT_REACHED(); };
> 
> don't add

done

>> Source/WebCore/storage/IDBDatabaseCallbacksImpl.h:42
>> +    virtual ~IDBDatabaseCallbacksImpl() { }
> 
> Don't inline.

done

>> Source/WebCore/storage/IDBDatabaseCallbacksImpl.h:48
>> +    IDBDatabaseCallbacksImpl(IDBDatabase*);
> 
> newline after
> 
> explain why this needs to be weak in comment?

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.