[Webkit-unassigned] [Bug 56156] Add setting to always force compositing mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 11:01:05 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56156





--- Comment #8 from Daniel Sievers <sievers at google.com>  2011-03-15 11:01:05 PST ---
(From update of attachment 85747)
View in context: https://bugs.webkit.org/attachment.cgi?id=85747&action=review

>> Tools/DumpRenderTree/chromium/TestShell.h:204
>> +    bool m_forceCompositingMode;
> 
> m_forceCompositingMode => m_forceCompositingEnabled?  I don't mean to nit-pick you over names.  These other variables are called "enabled" is all.

Actually the ones with a verb are without the 'enabled' suffix, such as 'm_allowExternalPages', 'm_dumpWhenFinished'. I can change it though if you feel strongly about it :) Otherwise, I thought I'd keep the naming consistent across all the classes (and see other force*() functions in page/Settings.h).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list