[Webkit-unassigned] [Bug 56156] Add setting to always force compositing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56156





--- Comment #7 from Vangelis Kokkevis <vangelis at chromium.org>  2011-03-15 10:56:50 PST ---
> > > Source/WebCore/rendering/RenderLayerCompositor.cpp:114
> > > +    if (settings && settings->alwaysEnterCompositing()) {
> > 
> > We also need to test for m_hasAcceleratedCompositing.  That value is not available at the time the constructor gets called.  Things work fine since there's a check at the end of updateCompositingLayers but it seems somewhat inefficient to go ahead and do all the work, create the GraphicsLayer tree and then gut it all out of compositing isn't supported.
> 
> 
> Ok, I added a check for settings->acceleratedCompositingEnabled() in the constructor...
> 
> 

I don't think that test is sufficient.  There's a couple of other conditions that will turn m_hasAcceleratedCompositing off, especially bits that are set on the Client.  If you do keep this code in the constructor (which is probably fine) then there's not much point in adding that check. 

Other than that, I think the patch looks fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.